Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI upgrade tests: separate paths for upgrade v8.0.0 and v9.0.0 #7393

Closed
wants to merge 1 commit into from

Conversation

shlomi-noach
Copy link
Contributor

Description

Yesterday we released https://github.com/vitessio/vitess/releases/tag/v9.0.0. From now on, we want to have CI verify that our PRs have valid upgrade path from v9.0.0.

I'm still keeping upgrade tests for v8.0.0 although I think we may not need to run them anymore? Any code we contribute from now on goes to > v9.0.0 version, and therefore should not necessarily be compatible with v8.0.0? cc @deepthi

So now there's two distinct CI tests, one called upgrade8 and one called upgrade9.

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@deepthi
Copy link
Member

deepthi commented Jan 27, 2021

I'm still keeping upgrade tests for v8.0.0 although I think we may not need to run them anymore? Any code we contribute from now on goes to > v9.0.0 version, and therefore should not necessarily be compatible with v8.0.0?

That is correct.
We should plan to backport new migration tests to 9.0 and have them run against v8.0.0.

@shlomi-noach
Copy link
Contributor Author

replaced by #7848

@shlomi-noach shlomi-noach deleted the ci-upgrade-v9 branch April 13, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants