Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vtctldclient] Set SilenceErrors on the root command, so we don't double-log #7404

Merged
merged 1 commit into from
Feb 2, 2021
Merged

[vtctldclient] Set SilenceErrors on the root command, so we don't double-log #7404

merged 1 commit into from
Feb 2, 2021

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Jan 28, 2021 •
edited by askdba
Loading

Description

What it says in the title. I noticed this while I was doing testing for #7395.

Before (SilenceErrors: false):

❯ vtctldclient --server "localhost:15999" DeleteKeyspace commerce >/dev/null
Error: DeleteKeyspace(commerce) error: rpc error: code = Unknown desc = keyspace commerce still has 1 shards; use Recursive=true or remove them manually; please check the topo
E0127 20:20:34.651188   89060 main.go:42] DeleteKeyspace(commerce) error: rpc error: code = Unknown desc = keyspace commerce still has 1 shards; use Recursive=true or remove them manually; please check the topo

After (SilenceErrors: true):

❯ vtctldclient --server "localhost:15999" DeleteKeyspace commerce >/dev/null
E0127 20:21:43.410431   89307 main.go:42] DeleteKeyspace(commerce) error: rpc error: code = Unknown desc = keyspace commerce still has 1 shards; use Recursive=true or remove them manually; please check the topo

Related Issue(s)

Checklist

  • Should this PR be backported? No
  • Tests were added or are not required N/A
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

@ajm188
Set SilenceErrors on the root command, so we don't double-log
2092f20 
Signed-off-by: Andrew Mason <amason@slack-corp.com>
@ajm188 ajm188 requested a review from doeg January 28, 2021 01:31
deepthi
deepthi approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepthi deepthi merged commit 0c99c57 into vitessio:master Feb 2, 2021
@ajm188 ajm188 deleted the am_vtctldclient_silence_errors branch February 2, 2021 23:25
ajm188 pushed a commit to tinyspeck/vitess that referenced this pull request Feb 11, 2021
@deepthi @ajm188
Merge pull request vitessio#7404 from tinyspeck/am_vtctldclient_silen…
d71cf9c 
…ce_errors

[vtctldclient] Set `SilenceErrors` on the root command, so we don't double-log
@ajm188 ajm188 mentioned this pull request Feb 11, 2021
Closed
setassociative pushed a commit to tinyspeck/vitess that referenced this pull request Mar 11, 2021
@deepthi @setassociative
Merge pull request vitessio#7404 from tinyspeck/am_vtctldclient_silen…
1032ee6 
…ce_errors

[vtctldclient] Set `SilenceErrors` on the root command, so we don't double-log
rafael pushed a commit to tinyspeck/vitess that referenced this pull request Apr 6, 2021
@deepthi @rafael
Merge pull request vitessio#7404 from tinyspeck/am_vtctldclient_silen…
e99a9ab 
…ce_errors

[vtctldclient] Set `SilenceErrors` on the root command, so we don't double-log
@ajm188 ajm188 mentioned this pull request Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doeg doeg doeg approved these changes

@deepthi deepthi deepthi approved these changes

Assignees
No one assigned
Labels
Component: Cluster management Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajm188 @deepthi @doeg @askdba