more resilient rebuild keyspace graph check, tablet controls not in e… #7442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ffect if there has no actual disabled query service Signed-off-by: hzhou <hzhou@pinterest.com>
rohit-nayak-ps
approved these changes
Feb 4, 2021
|
@inexplicable can you please create an issue that documents the problem and link it to this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After some emergency fix post split shard (SwitchWrites), we have some lingering tablet controls left in the partitions.
And those're blocking RebuildKeyspaceGraph due to the rigid check of any tablet controls even if there's no actual disabled service
Related Issue(s)
Fixes #7503
Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: