Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MoveTables/Reshard: add flags to start workflows in a stopped state and to stop workflow once copy is completed #7449

Merged
merged 6 commits into from
Feb 11, 2021

Conversation

rohit-nayak-ps
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps commented Feb 4, 2021

Description

Details in the related issue #7452

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

go/vt/vtctl/vtctl.go Outdated Show resolved Hide resolved
go/vt/vtctl/vtctl.go Outdated Show resolved Hide resolved
go/vt/wrangler/resharder.go Show resolved Hide resolved
…fter copy is done

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, otherwise LGTM

go/vt/wrangler/materializer.go Outdated Show resolved Hide resolved
go/vt/wrangler/resharder.go Outdated Show resolved Hide resolved
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps requested review from shlomi-noach and removed request for shlomi-noach February 10, 2021 08:38
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@deepthi deepthi merged commit 31a43f5 into vitessio:master Feb 11, 2021
@deepthi deepthi deleted the rn-vr-mt-stop-flags branch February 11, 2021 23:25
@askdba askdba added this to the v10.0 milestone Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to start MoveTables in a Stopped state or to stop after the copy phase
5 participants