Enable -mysql_server_version in vttestserver, and utilize it in vttestserver container images #7474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 9, 2021 12:57
…erverVersion downstream Signed-off-by: Mike Cronce <mc@planetscale.com>
Signed-off-by: Mike Cronce <mc@planetscale.com>
mcronce
requested review from
derekperkins,
dkhenry and
sougou
as code owners
harshit-gangal
approved these changes
Feb 9, 2021
deepthi
reviewed
Feb 9, 2021
| @@ -55,4 +55,4 @@ COPY --from=builder --chown=vitess:vitess /vt/install /vt | |||
| VOLUME /vt/vtdataroot | |||
| USER vitess | |||
|
|
|||
| CMD /vt/bin/vttestserver -port $PORT -keyspaces $KEYSPACES -num_shards $NUM_SHARDS -mysql_bind_host ${MYSQL_BIND_HOST:-127.0.0.1} | |||
| CMD /vt/bin/vttestserver -port $PORT -keyspaces $KEYSPACES -num_shards $NUM_SHARDS -mysql_bind_host ${MYSQL_BIND_HOST:-127.0.0.1} -mysql_server_version 5.7.9-vitess | |||
There was a problem hiding this comment.
It will be nice to allow users to override this with an env variable.
We can default to 5.7.9-Vitess which is the internal default as well.
| @@ -55,4 +55,4 @@ COPY --from=builder --chown=vitess:vitess /vt/install /vt | |||
| VOLUME /vt/vtdataroot | |||
| USER vitess | |||
|
|
|||
| CMD /vt/bin/vttestserver -port $PORT -keyspaces $KEYSPACES -num_shards $NUM_SHARDS -mysql_bind_host ${MYSQL_BIND_HOST:-127.0.0.1} | |||
| CMD /vt/bin/vttestserver -port $PORT -keyspaces $KEYSPACES -num_shards $NUM_SHARDS -mysql_bind_host ${MYSQL_BIND_HOST:-127.0.0.1} -mysql_server_version 8.0.0-vitess | |||
There was a problem hiding this comment.
We should probably use a current mysql version - say 8.0.21.
To make this more usable, how about adding an env variable similar to the others and defaulting to 8.0.21-Vitess?
| @@ -247,6 +247,9 @@ func VtcomboProcess(env Environment, args *Config, mysql MySQLManager) *VtProces | |||
| if args.VSchemaDDLAuthorizedUsers != "" { | |||
| vt.ExtraArgs = append(vt.ExtraArgs, []string{"-vschema_ddl_authorized_users", args.VSchemaDDLAuthorizedUsers}...) | |||
| } | |||
| if *servenv.MySQLServerVersion != "" { | |||
There was a problem hiding this comment.
This is cool. I thought we would have to add an arg.
There was a problem hiding this comment.
That was what I tried first, but it failed because this one was already being pulled in :)
…and change the :mysql80 default from 8.0.0-vitess to 8.0.21-vitess Signed-off-by: Mike Cronce <mc@planetscale.com>
dkhenry
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exposes the
-mysql_server_versionparameter invttestserver, and changes thevitess/vttestservercontainer images to set it appropriately.Related Issue(s)
Checklist
Deployment Notes
N/A - only impacts new
vttestserverrunsImpacted Areas in Vitess
Components that this PR will affect: