Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[reparentutil / wrangler] Extract PlannedReparentShard logic from wrangler to PlannedReparenter struct #7501

Merged
merged 7 commits into from
Feb 18, 2021
Merged

[reparentutil / wrangler] Extract PlannedReparentShard logic from wrangler to PlannedReparenter struct #7501

merged 7 commits into from
Feb 18, 2021

Commits on Feb 16, 2021

  1. Add PlannedReparenter struct to encapsulate the logic involved in a… 

    … PRS

This will eventually replace the equivalent logic in wrangler, which can
then delegate into this module, along with `VtctldServer` when we add
PRS to that API.

Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    d26d32a View commit details
    Browse the repository at this point in the history

  2. Add ForceSetShardMaster option to AddTablet* testutil functions 

    This allows conveniently setting up a shard with multiple tablets
claiming to be MASTER, with the shard be correctly configured to have
_a_ serving master. Previously, those were mutually-exclusive setups
with `AddTablets`.

Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    3a6fc8b View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2021

  1. Add PlannedReparenter tests 

    - add preflightChecks tests
- add test cases for `performPartialPromotionRecovery`
- remove unused arg, add test cases for `performPotentialPromotion`
- add missing call to waitgroup add
- add test cases for `reparentTablets`
- add tests for graceful promotion
- add the rest of the PlannedReparenter tests

Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    e7562fe View commit details
    Browse the repository at this point in the history

  2. Remove legacy PRS implementation in wrangler, delegate to reparentutil 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    ba19634 View commit details
    Browse the repository at this point in the history

  3. Bugfix: SetMaster call should not specify a wait position 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    1079a4a View commit details
    Browse the repository at this point in the history

  4. Update error substrings used in PRS test assertions 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    1554187 View commit details
    Browse the repository at this point in the history

  5. Fix typo in comments 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    f6913d4 View commit details
    Browse the repository at this point in the history