Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds another case to merge routes for information_schema queries #7504

Merged
merged 4 commits into from
Feb 21, 2021
Merged

Adds another case to merge routes for information_schema queries #7504

merged 4 commits into from
Feb 21, 2021

Conversation

GuptaManan100
Copy link
Member

@GuptaManan100 GuptaManan100 commented Feb 17, 2021 •
edited
Loading

Fixes #7376

@GuptaManan100
Added another case to merge routes for information_schema queries
c7f8d4f 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
harshit-gangal
harshit-gangal reviewed Feb 17, 2021
View reviewed changes
go/vt/sqlparser/ast_funcs.go Outdated Show resolved Hide resolved
go/vt/sqlparser/ast_funcs.go Outdated Show resolved Hide resolved
go/vt/sqlparser/ast.go Outdated Show resolved Hide resolved
@Akilan1999
Merge branch 'master' of https://github.com/vitessio/vitess into merg…
af84bae 
…e-information-schema

Signed-off-by:  <akilan.selvacoumar@planetscale.com>
@harshit-gangal
Copy link
Member

ast does not have to do with what the table qualifier is, we can move the ContainsOnlySystemSchema() logic from ast to logical plan and they can provide the same information needed for planner.

cc: @systay

@Akilan1999
simplified opt code instead of using AST
4cd2a7a 
Signed-off-by: Akilan Selvacoumar <akilan.selvacoumar@planetscale.com>

Signed-off-by:  <akilan.selvacoumar@planetscale.com>
harshit-gangal
harshit-gangal approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@harshit-gangal harshit-gangal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One nit comment

go/vt/sqlparser/ast_funcs.go Outdated Show resolved Hide resolved
GuptaManan100
GuptaManan100 commented Feb 18, 2021
View reviewed changes
go/vt/vtgate/planbuilder/route.go Outdated Show resolved Hide resolved
go/vt/sqlparser/cached_size.go Show resolved Hide resolved
@GuptaManan100
cleanup and addition of one more test
41c0f2f 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@harshit-gangal harshit-gangal merged commit 02376a3 into vitessio:master Feb 21, 2021
@ajm188 ajm188 mentioned this pull request Jul 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akilan1999 Akilan1999 Akilan1999 approved these changes

@systay systay Awaiting requested review from systay

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal

Assignees

@Akilan1999 Akilan1999

@GuptaManan100 GuptaManan100

Labels
Component: Query Serving Type: Bug
Projects
None yet
Milestone
No milestone
3 participants
@GuptaManan100 @harshit-gangal @Akilan1999