mysql/server: add PreHandleFunc hook for connections #7513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatih
force-pushed
the
fatih/add-pre-handle-hook
branch
from
54e571f
to
32b90f6
Compare
systay
approved these changes
Feb 18, 2021
systay
reviewed
Feb 18, 2021
This PR adds a new `PreHandleFunc` field to the Listener struct. The goal of this hook is to inspect the connection or add a custom TLS termination. Because MySQL does TLS termination differently, it'll allow us to terminate first and then let the handler continue processing the connection according to the MySQL protocol. I iniatally wanted it to make a part of the `Handler` interface, but that would be breaking change. If we're ok breaking it, I can make it part of the handler. Signed-off-by: Fatih Arslan <ftharsln@gmail.com>
fatih
force-pushed
the
fatih/add-pre-handle-hook
branch
from
0467f38
to
517e373
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
PreHandleFuncfield to the Listener struct. Thethe goal of this hook is to inspect the connection or add a custom
TLS termination. Because MySQL does TLS termination differently, it'll
allow us to terminate first and then let the handler continue processing
the connection according to the MySQL protocol.
I initially wanted it to make a part of the
Handlerinterface, butthat would be a breaking change. If we're ok breaking it, I can make it
part of the handler.