[vtctld | tests only] testtmclient refactor #7518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Mason <amason@slack-corp.com>
This frees up that name for a type in the next commit Signed-off-by: Andrew Mason <amason@slack-corp.com>
Only change was the type name, and the addition of documentation. Signed-off-by: Andrew Mason <amason@slack-corp.com>
… tests Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
ajm188
requested review from
deepthi,
doeg,
setassociative and
rohit-nayak-ps
doeg
reviewed
Feb 18, 2021
| // on each other during VtctldServer initialization, but still run the rest of | ||
| // the test in parallel. | ||
| // | ||
| // NOTE, THE FIRST: It is only safe to use in parallel with other tests using |
ajm188
force-pushed
the
am_testtmclient_refactor
branch
from
94f1aee
to
12c6437
Compare
doeg
approved these changes
Feb 19, 2021
ajm188
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Mar 5, 2021
[vtctld | tests only] testtmclient refactor Conflicts: go/vt/vtadmin/api_test.go go/vt/vtctl/reparentutil/emergency_reparenter_test.go go/vt/vtctl/reparentutil/planned_reparenter_test.go Resolved by `git rm -f` those files. Note: Also includes a change to grpcvtctldclient/client_test.go, not in the cherry-picked commit, to use the testutil constructor for vtctldservers. Signed-off-by: Andrew Mason <amason@slack-corp.com> wip test fixes Signed-off-by: Andrew Mason <amason@slack-corp.com>
setassociative
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Mar 11, 2021
[vtctld | tests only] testtmclient refactor Conflicts: go/vt/vtadmin/api_test.go go/vt/vtctl/reparentutil/emergency_reparenter_test.go go/vt/vtctl/reparentutil/planned_reparenter_test.go Resolved by `git rm -f` those files. Note: Also includes a change to grpcvtctldclient/client_test.go, not in the cherry-picked commit, to use the testutil constructor for vtctldservers. Signed-off-by: Andrew Mason <amason@slack-corp.com> wip test fixes Signed-off-by: Andrew Mason <amason@slack-corp.com> Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
rafael
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Apr 6, 2021
[vtctld | tests only] testtmclient refactor Note: Manually deleted api_test.go due to cherry-pick conflict Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR unifies the various mock tmclient implementations I've added for testing different vtctld functions. It also moves us further from a singleton mocking pattern, which will let us parallelize our test suite even further.
Related Issue(s)
Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: