Add mysqlctl docker image #7557
Conversation
|
@deepthi Could you have a look at this PR? Thanks |
Signed-off-by: Kewei Shang <kewei.shang@bolt.eu>
Signed-off-by: Kewei Shang <kewei.shang@bolt.eu>
keweishang
force-pushed
the
add-mysqlctl-docker-image
branch
from
04a3452
to
9053ddd
Compare
| COPY --from=k8s /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ca-certificates.crt | ||
|
|
||
| # copy vitess config | ||
| COPY --from=k8s /vt/config /vt/config |
There was a problem hiding this comment.
I'm not sure if the directory /vt/config is needed here? I'm copying it here because the mysqlctld docker image has it too.
Ideally, it'd be great if this docker image is more useful than just serving my purpose, which is to copy the /vt/bin/mysqlctl binary from this image (e.g. see example here).
There was a problem hiding this comment.
/vt/config contains mysql .cnf files so it is probably required.
There was a problem hiding this comment.
I'm going to approve this as-is, though in the long-term we should stop using the k8s base image altogether and unify / reduce the number of docker images we produce.
cc @derekperkins
|
Shall we merge the PR? @derekperkins @deepthi |
I'm about to. I will build and push a docker image later today. |
|
I've pushed a |
|
Thank you very much @deepthi! Having the |
Description
The Vitess Connector is using the
vitess/basedocker image as the base image to copy useful binaries, such asmysqlctl,vtctl, etc. Thevitess/basedocker image is huge (6.56GB). In order to avoid downloading this huge image, this PR creates themysqlctldocker image, so that users can copymysqlctlfrom this much smaller docker image.The new docker image
vitess/mysqlctlshould be pushed to DockerHub.Related Slack discussion: https://vitess.slack.com/archives/C0PQY0PTK/p1612339740175400
Impacted Areas in Vitess
Components that this PR will affect: