Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for SELECT ALL #7593

Merged
merged 1 commit into from
Mar 3, 2021
Merged

add support for SELECT ALL #7593

merged 1 commit into from
Mar 3, 2021

Conversation

systay
Copy link
Collaborator

@systay systay commented Mar 3, 2021 •
edited
Loading

Adds parser support for SELECT ALL. Since ALL is redundant, it is not kept in the AST.

Fixes #7561

Checklist

  • Should this PR be backported? Nope
  • Tests were added or are not required Not required
  • Documentation was added or is not required Not needed

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving

@systay
add support for SELECT ALL
a1f5bb1 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay merged commit ed545f7 into vitessio:master Mar 3, 2021
@systay systay deleted the select-all branch March 3, 2021 14:44
@askdba askdba added this to the v10.0 milestone Mar 4, 2021
@ajm188 ajm188 mentioned this pull request Jul 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100

Assignees
No one assigned
Labels
Component: Query Serving
Projects
None yet
Milestone
v10.0
Development

Successfully merging this pull request may close these issues.

Support SELECT ALL
3 participants
@systay @harshit-gangal @askdba