Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vtadmin] Add FindSchema route #7610

Merged
merged 3 commits into from
Mar 6, 2021
Merged

[vtadmin] Add FindSchema route #7610

merged 3 commits into from
Mar 6, 2021

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Mar 4, 2021

Description

This PR adds an endpoint to find a globally (cross-cluster) unique table schema in vtadmin.

Related Issue(s)

Checklist

  • Should this PR be backported? No
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

@ajm188
Add FindSchema RPC, run generators and set up stubs
1eea798 
Signed-off-by: Andrew Mason <amason@slack-corp.com>
@ajm188
Implement FindSchema method and http wrapper
210458e 
Signed-off-by: Andrew Mason <amason@slack-corp.com>
@ajm188
Refactor testutils, add tests for FindSchema
b5b0713 
Signed-off-by: Andrew Mason <amason@slack-corp.com>
doeg
doeg approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@doeg doeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. One non-blocking question.

go/vt/vtadmin/api.go Show resolved Hide resolved
@ajm188 ajm188 mentioned this pull request Mar 4, 2021
Open
@rohit-nayak-ps rohit-nayak-ps merged commit 2b18baa into vitessio:master Mar 6, 2021
@doeg doeg added the Component: VTAdmin VTadmin interface label Mar 16, 2021
@ajm188 ajm188 deleted the am_vtadmin_find_schema branch May 29, 2021 10:25
@ajm188 ajm188 mentioned this pull request Jul 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doeg doeg doeg approved these changes

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps

Assignees
No one assigned
Labels
Component: VTAdmin VTadmin interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add FindSchema route to vtadmin
3 participants
@ajm188 @doeg @rohit-nayak-ps