Fix for reserved connection usage with transaction #7646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
1. Update the shard sessions only if there is any update i.e. updated transaction id or updated reserved id 2. If there is failure to execute BeginExecute api and the connection is reserved conn then check if shard session can be reset and execute ReserveBeginExecute api Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…erve connection Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
deepthi
approved these changes
Mar 9, 2021
| exec(t, conn, `insert into allDefaults () values ()`) | ||
| exec(t, conn, `commit`) | ||
|
|
||
| time.Sleep(6 * time.Second) |
There was a problem hiding this comment.
I don't suppose this can be made any faster?
There was a problem hiding this comment.
transaction timeout is 3 seconds and this is to ensure that transaction killer is run.
| @@ -447,7 +447,7 @@ func (sbc *SandboxConn) HandlePanic(err *error) { | |||
| //ReserveBeginExecute implements the QueryService interface | |||
| func (sbc *SandboxConn) ReserveBeginExecute(ctx context.Context, target *querypb.Target, preQueries []string, sql string, bindVariables map[string]*querypb.BindVariable, options *querypb.ExecuteOptions) (*sqltypes.Result, int64, int64, *topodatapb.TabletAlias, error) { | |||
| reservedID := sbc.reserve(ctx, target, preQueries, bindVariables, 0, options) | |||
| result, transactionID, alias, err := sbc.BeginExecute(ctx, target, preQueries, sql, bindVariables, reservedID, options) | |||
| result, transactionID, alias, err := sbc.BeginExecute(ctx, target, nil, sql, bindVariables, reservedID, options) | |||
There was a problem hiding this comment.
this was wrong test setup, so fixed it.
prequeries were getting logged twice which was wrong.
systay
approved these changes
Mar 9, 2021
|
For searchability purposes; since there isn't an issue associated with this, here is the type of error that this PR addresses: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue is when the session is in reserved connection and the connection is timeout.
Next time there is a transaction, that failed with a weird error of tablet alias not matching.
The fix has three parts.
Checklist
Impacted Areas in Vitess
Components that this PR will affect: