tabletserver: more resilient wait for schema changes #7684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vicent Marti <vmg@strn.cat>
vmg
requested review from
harshit-gangal,
shlomi-noach and
systay
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@shlomi-noach has detected a flaky test (e.g. https://github.com/vitessio/vitess/pull/7663/checks?check_run_id=2109940790) which I suspect is related to
SchemaChangedevents flushing our cache in the middle of a test. The current version of the test just sleeps for a small while to prevent this, but in practice this may not be enough. A new helper method has been introduced that waits forTseconds without anySchemaChangedevents, because at the start of these tests we can see more than one of these events, which may lag between each other.Related Issue(s)
Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: