Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tabletserver: more resilient wait for schema changes #7684

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

vmg
Copy link
Collaborator

@vmg vmg commented Mar 15, 2021

Description

@shlomi-noach has detected a flaky test (e.g. https://github.com/vitessio/vitess/pull/7663/checks?check_run_id=2109940790) which I suspect is related to SchemaChanged events flushing our cache in the middle of a test. The current version of the test just sleeps for a small while to prevent this, but in practice this may not be enough. A new helper method has been introduced that waits for T seconds without any SchemaChanged events, because at the start of these tests we can see more than one of these events, which may lag between each other.

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

Signed-off-by: Vicent Marti <vmg@strn.cat>
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧯

@shlomi-noach shlomi-noach merged commit 58f526e into vitessio:master Mar 15, 2021
@askdba askdba added this to the v10.0 milestone Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants