COM_PREPARE - Single TCP response packet with all MySQL Packets #7713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ommand Signed-off-by: Harshit Gangal <harshit@planetscale.com>
|
nice stuff! are the more situations where we could lump together mysql packets like this? |
systay
approved these changes
Mar 19, 2021
Other place is COM_FIELD_LIST Response and COM_STMT_FETCH Response which currently we do not support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For each column defination we send a seperate TCP packet containing the MySQL Packet.
This change is to send single TCP packet containing all the MySQL Packets for COM_PREPARE.
This is similar to what MySQL does.
Checklist
Impacted Areas in Vitess
Components that this PR will affect: