Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

making fast AST rewriter faster #7726

Merged
merged 6 commits into from
Mar 23, 2021
Merged

making fast AST rewriter faster #7726

merged 6 commits into from
Mar 23, 2021

Commits on Mar 22, 2021

  1. remove err and for loop index close from the rewriter generated code 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    b1a9944 View commit details
    Browse the repository at this point in the history

  2. return bool than error from rewriter methods 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    ad9cad6 View commit details
    Browse the repository at this point in the history

  3. fixed unit test 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    fde4038 View commit details
    Browse the repository at this point in the history

  4. changed rewiter api signarature by removing error in the return param… 

    …eters

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    4995638 View commit details
    Browse the repository at this point in the history

  5. remove unused err from the code 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    6ba9b2b View commit details
    Browse the repository at this point in the history

  6. fix asthelpers integ tests 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    ed6b0e5 View commit details
    Browse the repository at this point in the history