Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show columns query on system schema #7729

Merged
merged 1 commit into from
Mar 23, 2021
Merged

show columns query on system schema #7729

merged 1 commit into from
Mar 23, 2021

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Mar 23, 2021 •
edited
Loading

Description

Earlier the query failed with error

"show full columns from sys.sys_config"
keyspace sys not found in vschema

Fix is to send this to any shard of any keyspace as system schema does not change.

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving

@harshit-gangal
show columns query on system schema
7313a96 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal requested a review from systay March 23, 2021 12:44
@harshit-gangal harshit-gangal marked this pull request as ready for review March 23, 2021 12:58
@harshit-gangal harshit-gangal merged commit 9b09bfa into vitessio:master Mar 23, 2021
@harshit-gangal harshit-gangal deleted the more-sys-fix branch March 23, 2021 19:47
@askdba askdba added this to the v10.0 milestone Mar 26, 2021
@ajm188 ajm188 mentioned this pull request Jul 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@systay systay systay approved these changes

Assignees
No one assigned
Labels
Component: Query Serving
Projects
None yet
Milestone
v10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@harshit-gangal @systay @askdba