Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Linux/amd64 specific subdependencies #7796

Merged
merged 3 commits into from
Apr 10, 2021

Conversation

shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented Apr 6, 2021

Description

Reported by @systay, the merging of #7725 introduced a subdependency github.com/moby/term which does not build on MacOS:

> make build
Tue Apr 6 14:14:12 CEST 2021: Building source tree
# github.com/moby/term
../go/pkg/mod/github.com/moby/term@v0.0.0-20200429084858-129dac9f73f6/tc.go:13:28: undefined: unix.SYS_IOCTL
../go/pkg/mod/github.com/moby/term@v0.0.0-20200429084858-129dac9f73f6/tc.go:18:28: undefined: unix.SYS_IOCTL
../go/pkg/mod/github.com/moby/term@v0.0.0-20200429084858-129dac9f73f6/termios_bsd.go:24:31: undefined: unix.SYS_IOCTL
../go/pkg/mod/github.com/moby/term@v0.0.0-20200429084858-129dac9f73f6/termios_bsd.go:37:31: undefined: unix.SYS_IOCTL
make: *** [build] Error 2

This is a subdependency of github.com/fsouza/go-dockerclient, which is in itself a dependency of tengo.

We already user our own fork of tengo. I've submitted and merged planetscale/tengo#5, which removes any docker references, none of which we use. This removes the dependencies on aforementioned libraries. I tagged as v0.9.6-ps.v2

This PR instructs go.mod to use v0.9.6-ps.v2.

Checklist

  • Should this PR be backported? (to v10)
  • Tests were added or are not required
  • Documentation was added or is not required

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

…, removing Linux/amd64 specific sub dependencies

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@deepthi
Copy link
Member

deepthi commented Apr 6, 2021

@gedgar created #7787 yesterday to fix the same issue. However, I'm not sure if that will stick because the go mod tidy test is failing right now on it.

@shlomi-noach
Copy link
Contributor Author

I ran go mod tidy and committed to #7787. If #7787 works, then I prefer that #7787 is merged over this PR, because this PR requires us to edit our fork of tengo and this causes maintainership pains.

@shlomi-noach
Copy link
Contributor Author

closing since #7787 fixed the problem in a different way.

@shlomi-noach shlomi-noach deleted the tengo-no-docker branch April 6, 2021 15:49
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach restored the tengo-no-docker branch April 8, 2021 15:12
@shlomi-noach shlomi-noach reopened this Apr 8, 2021
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Contributor Author

Again, dropped docker code from planetscale/tengo, and this removes dependency modules that are giving us some pains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants