Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GetSchema filtering to exclude shards where IsMasterServing but no MasterAlias #7805

Merged
merged 2 commits into from
Apr 8, 2021

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Apr 8, 2021

Signed-off-by: Andrew Mason amason@slack-corp.com

Description

This effectively accounts for corner cases where there is an empty shard which happens to also be marked as serving.

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

…` but no `MasterAlias`

Signed-off-by: Andrew Mason <amason@slack-corp.com>
@ajm188 ajm188 requested review from rafael and doeg April 8, 2021 00:41
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Copy link
Member

@rafael rafael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafael
Copy link
Member

rafael commented Apr 8, 2021

Looks good, let's merge when the tests pass.

@ajm188 ajm188 merged commit fe6d095 into vitessio:master Apr 8, 2021
@ajm188 ajm188 deleted the am_vtadmin_shardserving branch April 8, 2021 20:35
@askdba askdba added the Component: VTAdmin VTadmin interface label Apr 13, 2021
@askdba askdba added this to the v11.0 milestone Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VTAdmin VTadmin interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants