Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump MySQL version for docker builds to 8.0.23 #7811

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Bump MySQL version for docker builds to 8.0.23 #7811

merged 1 commit into from
Apr 9, 2021

Conversation

aquarapid
Copy link
Contributor

since the xtrabackup issue has been resolved.

  • Remove comment implying we do not support 8.0

Signed-off-by: Jacques Grove aquarapid@gmail.com

@aquarapid
* Bump MySQL version for docker builds to 8.0.23, since the xtrabackup
f80ad14 
issue has been resolved.

* Remove comment implying we do not support 8.0

Signed-off-by: Jacques Grove <aquarapid@gmail.com>
@aquarapid aquarapid requested a review from deepthi April 8, 2021 15:25
@aquarapid
Copy link
Contributor Author

Resolves #7812

dkhenry
dkhenry approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@dkhenry dkhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice on this we don't pin the version of xtra backup. Not going to block the PR on it, but since this is only fixed in newer versions of xtra backup it may be good to pin the version to a known good one

deepthi
deepthi approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Test failures look unrelated.

@deepthi deepthi merged commit bf97de0 into vitessio:master Apr 9, 2021
@deepthi deepthi deleted the jg_bump_mysql8 branch April 9, 2021 18:09
@askdba askdba added this to the v11.0 milestone Apr 13, 2021
@systay systay mentioned this pull request Apr 23, 2021
Merged
@deepthi deepthi mentioned this pull request Apr 27, 2021
Merged
8 tasks
@systay systay added Type: Enhancement Logical improvement (somewhere between a bug and feature) and removed Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkhenry dkhenry dkhenry approved these changes

@deepthi deepthi deepthi approved these changes

@derekperkins derekperkins Awaiting requested review from derekperkins

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach

@systay systay Awaiting requested review from systay

Assignees
No one assigned
Labels
Type: CI/Build
Projects
None yet
Milestone
v11.0
Development

Successfully merging this pull request may close these issues.
5 participants
@aquarapid @deepthi @dkhenry @systay @askdba