Memory Sort to close the goroutines when callback returns error #7903
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7908
Description
Merge sort is used when VTGate needs to merge the incoming sorted streams. The Bug was around if the callback returns and go routines that are handling those streams needs to be closed.
This is usually achieved by using cancellable context. The new context that was created was not passed to those goroutines so even the context was cancelled the goroutines were stuck waiting.
Checklist
Impacted Areas in Vitess
Components that this PR will affect: