Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show databases like #7912

Merged
merged 3 commits into from
Apr 27, 2021
Merged

Show databases like #7912

merged 3 commits into from
Apr 27, 2021

Conversation

GuptaManan100
Copy link
Member

@GuptaManan100 GuptaManan100 commented Apr 21, 2021

Description

This PR adds the default database names before the filtering step of SHOW DATABASE queries. Also adds tests for the same.

BEFORE

mysql> show databases like '%ys%';
+--------------------+
| Database (%ys%)    |
+--------------------+
| information_schema |
| mysql              |
| performance_schema |
| sys                |
+--------------------+

AFTER

mysql> show databases like '%ys%';
+-----------------+
| Database (%ys%) |
+-----------------+
| mysql           |
| sys             |
+-----------------+

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the before and after output into the PR? Either in the description or as a comment.

Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay merged commit 8bd5a7c into vitessio:master Apr 27, 2021
@systay systay deleted the show-databases-like branch April 27, 2021 11:49
@systay systay added Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SHOW DATABASES LIKE doesn't filter properly
4 participants