Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker/lite/install_dependencies.sh: If the dependency install loop reaches its max number of retries, consider that a failure; exit the script nonzero so the build halts. #7976

Conversation

mcronce
Copy link

@mcronce mcronce commented Apr 28, 2021

Description

In #7943, we fixed the vitess/lite:mysql80 build; however, we observed that a failure to install dependencies was still "successfully" building a container image.

This fixes that - if installing dependencies fails enough times to exhaust the retry loop, we will now exit nonzero.

Tested manually by reverting #7943 in my local copy and attempting a build. It failed, as expected.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

…eaches its max number of retries, consider that a failure; exit the script nonzero so the build halts.

Signed-off-by: Mike Cronce <mc@planetscale.com>
@systay systay added Type: CI/Build Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Build/CI and removed Type: CI/Build labels Apr 28, 2021
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@deepthi deepthi merged commit 00a649f into vitessio:master Apr 28, 2021
@deepthi deepthi deleted the fail-docker-lite-build-when-deps-cant-install branch April 28, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Build/CI Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants