Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing return on a failed GetShard call in FindAllShardsInKeyspace #7992

Merged
merged 1 commit into from
May 4, 2021

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Apr 29, 2021

Signed-off-by: Andrew Mason amason@slack-corp.com

Description

I caught this while setting up errcheck in our linter, and I'm glad I did!

Related Issue(s)

Checklist

  • Tests were added or are not required
    • @deepthi I'm not sure how to force a failure on a single GetShard call (without failing the earlier GetShardNames call) in order to write a test case; do you have any ideas/suggestions?
  • Documentation was added or is not required => n/a

Deployment Notes

…space`

Signed-off-by: Andrew Mason <amason@slack-corp.com>
@ajm188 ajm188 requested a review from deepthi April 29, 2021 02:24
@ajm188 ajm188 requested a review from rafael as a code owner April 29, 2021 02:24
Copy link
Member

@rafael rafael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafael rafael merged commit 8e0531f into vitessio:master May 4, 2021
@ajm188 ajm188 deleted the am_missing_return branch May 29, 2021 10:25
ajm188 pushed a commit to tinyspeck/vitess that referenced this pull request Jul 23, 2021
Add missing return on a failed `GetShard` call in `FindAllShardsInKeyspace`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants