Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new hook called
vttablet_restore_done
, which fires, in a background goroutine, whenever a tablet has finished restoring. In the case where a restore failed, we include the error string in the hook env.We also now track start/stop time of
restoreDataLocked
, and provide both of those as utc RFC3339 timestamps in the env, as well as the standard Go-formatted duration ofstop - start
.Finally, I also updated the default
tabletmanager.hookExtraEnv
to include the tablet's keyspace and shard.Local example
No hook
Snippet of tablet logs:
trivial hook
Snippet of tablet logs:
Related Issue(s)
Checklist
Deployment Notes