Online DDL: progress & ETA for Vreplication migrations #8015
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#7980 introduced VReplicaiton tracking for
rows_copied
. This PR both intensifies that tracking, and follows up in Online DDL: the online DDL executor periodically checksrows_copied
from_vt.vstream
, compares with estimatedtable_rows
, looks atstarted_timestamp
, and generates values forprogress
and foreta_seconds
.Online DDL does so every 1 minute, normally, which means the valuee
progress
andeta_seconds
are estimates only. Plus,vcopier
itself only updatesrows_copied
every30s
, so we could get almost a90s
stale value forprogress
andeta_seconds
. Which is acceptable to us at this tim.Related Issue(s)
rows_copied
#7980Checklist
Deployment Notes