Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the provided keyspace through to UpdateDisableQueryService rather than hard-coding the sourceKeyspace #8020

Merged
merged 1 commit into from
May 3, 2021

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented May 3, 2021

Signed-off-by: Andrew Mason amason@slack-corp.com

Description

See #8019 for details.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

…her than hard-coding the sourceKeyspace

Signed-off-by: Andrew Mason <amason@slack-corp.com>
@ajm188 ajm188 requested a review from deepthi as a code owner May 3, 2021 02:38
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ajm188 ajm188 merged commit 017c412 into vitessio:master May 3, 2021
@ajm188 ajm188 deleted the am_reshard_bugfix branch May 3, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VReplication: trafficswitcher's changeShardsAccess always operates on the source keyspace
3 participants