vreplication: fix vreplication timing metrics #8024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several of the vreplication metrics were recently updated to no longer be correct. Specifically time.Now() is no longer executed when the function starts and is instead executed when the defer statement is called after the end of the function. This updates the metrics to properly execute time.Now() at the start of the functions. Signed-off-by: Dylan Visher <dvisher@figma.com>
dyv
force-pushed
the
dvisher/vreplication-metrics
branch
from
25a52f5
to
d93ee91
Compare
shlomi-noach
approved these changes
May 3, 2021
There was a problem hiding this comment.
LGTM. Just to explain it a bit in golang terms:
in
defer func() {
vc.vr.stats.PhaseTimings.Record("catchup", time.Now())
}()the value of time.Now() is evaluated when the code inside the defer function runs, which is at the end of the catchup function.
In:
defer vc.vr.stats.PhaseTimings.Record("catchup", time.Now())the value of time.Now() is evaluated immediately, and cached until the deferred function is actually invoked.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Several of the vreplication metrics were recently updated to no longer be
correct. Specifically time.Now() is no longer executed when the function
starts and is instead executed when the defer statement is called after the end
of the function.
This updates the metrics to properly execute time.Now() at the start
of the functions.