Make TwoPC engine initialization async. #8048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
sufficient. Signed-off-by: Jacques Grove <aquarapid@gmail.com>
aquarapid
changed the title
aquarapid
requested review from
harshit-gangal,
shlomi-noach and
systay
as code owners
|
Some of the TwoPC tests are failing now. |
Yeah, I guess since they start issuing TXes immediately. I'll take a look. |
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
tests Signed-off-by: Jacques Grove <aquarapid@gmail.com>
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
deepthi
reviewed
May 7, 2021
| @@ -453,6 +453,11 @@ func (tsv *TabletServer) TableGC() *gc.TableGC { | |||
| return tsv.tableGC | |||
| } | |||
|
|
|||
| // TwoPCEngineWait waits until the TwoPC engine has been opened, and the redo read | |||
| func (tsv *TabletServer) TwoPCEngineWait() { | |||
There was a problem hiding this comment.
nit: rename to WaitForTwoPCEngine
harshit-gangal
approved these changes
May 7, 2021
|
Also need a corresponding issue. |
deepthi
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a "deadlock" here if you use semi-sync and
twopc during a failover, because we open the twopc
engine first, and it immediately tries to create its
metadata tables in
_vt. On the PRS target, thatthen hangs if using semi-sync, and since the code
to do the repointing of the replicas to the new master
sits "behind" the twopc engine open, the PRS would
never complete.
Signed-off-by: Jacques Grove aquarapid@gmail.com