Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vtadmin-web] Add initial Stream view, render streams on Workflow view #8091

Merged
merged 4 commits into from
May 10, 2021
Merged

[vtadmin-web] Add initial Stream view, render streams on Workflow view #8091

merged 4 commits into from
May 10, 2021

Conversation

doeg
Copy link
Contributor

@doeg doeg commented May 10, 2021

Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com

Description

An initial (and interim) implementation for:

  • Rendering streams on the Workflow view
  • Rendering a single stream (........ "rendering" as JSON, that is 🙈) on the Stream view

All workflows:
Screen Shot 2021-05-10 at 2 31 12 PM

A single workflow:
Screen Shot 2021-05-10 at 2 31 14 PM

Screen Shot 2021-05-10 at 2 32 12 PM

"""Stream detail view""" (lol)
Screen Shot 2021-05-10 at 2 31 20 PM

Related Issue(s)

N/A

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

N/A

doeg added 2 commits May 10, 2021 14:28
@doeg
[vtadmin-web] Add Stream view, render streams on Workflow view
a8cf05c 
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg
[vtadmin-web] Set 1s refetch interval on Stream/Worflow views
ee8eb66 
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
doeg added 2 commits May 10, 2021 14:38
@doeg
[vtadmin-web] Adjust font weight on stream list
5daca79 
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg
[vtadmin-web] Sort streams by stream key
4dc2dd4 
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
ajm188
ajm188 approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajm188 ajm188 merged commit 6fa00f9 into vitessio:master May 10, 2021
@doeg doeg deleted the sarabee-workflow-details branch May 10, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajm188 ajm188 ajm188 approved these changes

@rafael rafael Awaiting requested review from rafael

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps

Assignees
No one assigned
Labels
Component: VTAdmin VTadmin interface Type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doeg @ajm188