Fix for issue with information_schema queries with both table name and schema name predicates #8096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport of vitessio#7841 * made sysTableTableSchema a slice and fixed merging for SelectDBA queries * updated tests * added tests * changed error message Signed-off-by: GuptaManan100 <manan@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com>
Backport of vitessio#8087 This is a combination of 4 commits. * add e2e test for system schema * add unit test for system schema issue * redirect to default route if not able to resolve the keyspace in case of information_schema query * update test with new error message Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com>
harshit-gangal
approved these changes
May 11, 2021
systay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of two related information schema PRs: #7841 and #8087
The bugfix we wanted to backport is in #8087, and it depends on #7841