-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vtctld] Migrate ApplyVSchema
to VtctldServer
#8113
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
cb21654
implement ApplyVSchema in grpc-vtctld
335e880
added skip_rebuild and v_schema to message types
7ce57de
added command line interface
1852224
recompiled protos after rebase
640af1e
rebuild protos and client_gen
5c85d70
added a test
6632d48
allow sql_mode or json_mode on the server-side
2b4ab4c
add more tests; which compile, but do not pass
785c3b6
tests passing
4f325fe
remove the single letter versions of these flags
d63a4ce
no vttime alias; underscore -> hyphen
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A net-new thing (that you could not have known!) I'm trying to introduce is:
DisableFlagsInUseLine: true
on every command. This will change the help from{{ .Use }} [flags]
to just{{ .Use }}
(which is better, because you include the actual named flags in the Use string)..Short
help text, which in most cases I just copy from the old vtctl command.