Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse generated columns in DDL #8117

Merged
merged 10 commits into from
May 13, 2021
Merged

Parse generated columns in DDL #8117

merged 10 commits into from
May 13, 2021

Conversation

systay
Copy link
Collaborator

@systay systay commented May 13, 2021 •
edited by deepthi
Loading

Description

Adds parser support for generated columns.

Related Issues

Fixes #8110

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

References

https://dev.mysql.com/doc/refman/5.7/en/create-table.html
https://dev.mysql.com/doc/refman/8.0/en/create-table-generated-columns.html

@systay
clean up parse tests around create table
cfdb5cc 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
add support for generated columns in DDL
5c6e13a 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
accept GENERATED ALWAYS when parsing column definition
657a9cf 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay marked this pull request as draft May 13, 2021 09:38
@shlomi-noach shlomi-noach mentioned this pull request May 13, 2021
Merged
2 tasks
@frouioui
Addition of parenthesis around AS' expression
8a0f88a 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Initial addition of generated column attribute list
773930a 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Printing option storage format
2ed59d1 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Refactored sql.y with new keys rule and added support for null, uniqu…
b82be4f 
…e, comment

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@systay systay marked this pull request as ready for review May 13, 2021 15:25
@systay systay requested a review from shlomi-noach May 13, 2021 15:25
@GuptaManan100
ran make parser
cde765f 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
add virtual and stored to reserved keywords
f73c483 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
deepthi
deepthi reviewed May 13, 2021
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good.
From the parser it looks like we now support generated columns in both CREATE and ALTER, however I don't see any tests for the ALTER case.

@deepthi
tests: parse tests for alter DDL with generated columns
6ff82cd 
Signed-off-by: deepthi <deepthi@planetscale.com>
deepthi
deepthi approved these changes May 13, 2021
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added parser unit tests for alter. LGTM now.

@deepthi deepthi merged commit 8442df3 into vitessio:master May 13, 2021
@deepthi deepthi deleted the feat-generated-always branch May 13, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@deepthi deepthi deepthi approved these changes

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach

Assignees
No one assigned
Labels
Component: Query Serving Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vitess should support GENERATED for Online DDL.
5 participants
@systay @deepthi @GuptaManan100 @askdba @frouioui