Correctly parse cell names with dashes in tablet aliases #8167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hormoz Kheradmand hormoz.kheradmand@shopify.com
Description
Closes #6041
vttablet fails to parse tablet-aliases with more than one
-
in the cell name.This is especially problematic because cells are often named after GCP/AWS zones, which are often valid DNS-1123 labels (consists of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character. see similar validation in the
kubernetes/kubernetes
repository)Since this parser has been out in the wild for a while, I am not sure how strict we want to make the format. I chose to include the capital alphabetic characters in addition to
.
,_
, and of course-
.I am happy to change the expected format to be any more or any less strict, as maintainers see fit.
Checklist
Deployment Notes
There are chances of invalid cell names out in the wild the more strict we make the expected format.
@deepthi @gedgar @harshit-gangal
cc @jeremycole @acharis