Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtadmin-web] The hastiest Tablet view (+ experimental debug vars) #8170

Merged
merged 1 commit into from
May 25, 2021

Conversation

doeg
Copy link
Contributor

@doeg doeg commented May 21, 2021

Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com

Description

  • Adds a very hasty Tablet view... who doesn't love un-highlighted JSON?
  • Adds links to external tablet pages (i.e., on the tablet itself) when the FQDN build flag is defined
  • Adds a feature flag + hooks, etc. for querying the experimental /debug/vars endpoint

I'm not going to include a screenshot since some of debug vars contain machine information. 😎 And.. y'know, it looks like JSON.

Related Issue(s)

N/A

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

N/A

Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg doeg added Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature) labels May 21, 2021
Copy link
Member

@guidoiaquinti guidoiaquinti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

if (!tq.isLoading && !tablet) {
return (
<div className={style.placeholder}>
<span className={style.errorEmoji}>😖</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you ❤️

@ajm188 ajm188 merged commit bb15f60 into vitessio:master May 25, 2021
@doeg doeg deleted the sarabee-vtadmin-web-tablet-vars branch May 25, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants