Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to vttestserver to pass -foreign_key_mode, -enable_online_ddl, and -enable_direct_ddl through to vtcombo #8177

Merged
merged 7 commits into from
May 27, 2021

Conversation

mcronce
Copy link

@mcronce mcronce commented May 24, 2021

Description

  • Add -foreign_key_mode, enable_online_ddl, and -enable_direct_ddl to vttestserver
  • Pass all three through to underlying vtcombo process
  • Add $FOREIGN_KEY_MODE, $ENABLE_ONLINE_DDL, and $ENABLE_DIRECT_DDL to vttestserver container image

Related Issue(s)

N/A

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

N/A

Mike Cronce added 5 commits May 24, 2021 17:35
…DDL, EnableDirectDDL

Signed-off-by: Mike Cronce <mc@planetscale.com>
…nline_ddl, -enable_direct_ddl

Signed-off-by: Mike Cronce <mc@planetscale.com>
…-enable_online_ddl, and -enable_direct_ddl into ExtraArgs

Signed-off-by: Mike Cronce <mc@planetscale.com>
…line

Signed-off-by: Mike Cronce <mc@planetscale.com>
…$ENABLE_DIRECT_DDL

Signed-off-by: Mike Cronce <mc@planetscale.com>
Copy link
Contributor

@dkhenry dkhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Mike Cronce added 2 commits May 27, 2021 14:16
Signed-off-by: Mike Cronce <mc@planetscale.com>
Signed-off-by: Mike Cronce <mc@planetscale.com>
@deepthi deepthi added Component: Build/CI Type: Enhancement Logical improvement (somewhere between a bug and feature) labels May 27, 2021
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Nice work on adding tests

@deepthi deepthi merged commit 1d649ea into vitessio:master May 27, 2021
@deepthi deepthi deleted the vttestserver-more-flags branch May 27, 2021 18:52
janpio added a commit to prisma/prisma-engines that referenced this pull request May 28, 2021
@mcronce mcronce mentioned this pull request Jun 1, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Build/CI Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants