-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options to vttestserver to pass -foreign_key_mode, -enable_online_ddl, and -enable_direct_ddl through to vtcombo #8177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DDL, EnableDirectDDL Signed-off-by: Mike Cronce <mc@planetscale.com>
…nline_ddl, -enable_direct_ddl Signed-off-by: Mike Cronce <mc@planetscale.com>
…-enable_online_ddl, and -enable_direct_ddl into ExtraArgs Signed-off-by: Mike Cronce <mc@planetscale.com>
…line Signed-off-by: Mike Cronce <mc@planetscale.com>
…$ENABLE_DIRECT_DDL Signed-off-by: Mike Cronce <mc@planetscale.com>
mcronce
force-pushed
the
vttestserver-more-flags
branch
from
May 24, 2021 21:35
50bd430
to
88d9792
Compare
dkhenry
approved these changes
May 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Mike Cronce <mc@planetscale.com>
Signed-off-by: Mike Cronce <mc@planetscale.com>
deepthi
added
Component: Build/CI
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
labels
May 27, 2021
deepthi
approved these changes
May 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nice work on adding tests
janpio
added a commit
to prisma/prisma-engines
that referenced
this pull request
May 28, 2021
Uses new features from vitessio/vitess#8177
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-foreign_key_mode
,enable_online_ddl
, and-enable_direct_ddl
tovttestserver
vtcombo
process$FOREIGN_KEY_MODE
,$ENABLE_ONLINE_DDL
, and$ENABLE_DIRECT_DDL
tovttestserver
container imageRelated Issue(s)
N/A
Checklist
Deployment Notes
N/A