Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online DDL/VReplication: test PK column case change #8336

Conversation

shlomi-noach
Copy link
Contributor

Description

Add test modify-change-case-pk which validates everything works well when changing the case of a PRIMARY KEY column, eg. from id to ID.

This just works with current logic and no changes were required to make this test pass.
BTW gh-ost actually fails that kind of change.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach requested a review from a team June 23, 2021 07:32
@shlomi-noach
Copy link
Contributor Author

ping for review

@shlomi-noach shlomi-noach merged commit e242a14 into vitessio:main Jun 29, 2021
@shlomi-noach shlomi-noach deleted the online-ddl-vrepl-suite-change-pk-column-case branch June 29, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants