Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround xtrabackup error using mysql global variable old_alter_table #8340

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented Jun 15, 2021

Description

Resubmission of #8317
Instead of backporting commits into earlier versions, we want to apply changes in earlier versions, then merge forward.
This will merge into release-9.0 branch

Copy of original comment from @deepthi :


Description

Some of the xtrabackup tests have been flaky for a while. Today @vmg was able to extract the actual error from a failing test.
This seems to be a known issue with a documented workaround. Implementing the workaround.
https://www.percona.com/blog/2017/08/08/avoiding-the-an-optimized-without-redo-logging-ddloperation-has-been-performed-error-with-percona-xtrabackup/

The blog post has 3 suggestions:

  • --lock-ddl : only works with Percona MySQL server, we are running community MySQL server in CI
  • --lock-ddl-per-table: did not fix the problem
  • old_alter_table: 🤞

Related Issue(s)

Fixes #8315

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@systay systay merged commit 5ef7323 into vitessio:release-9.0 Jun 15, 2021
@systay systay deleted the fix-8315-release-9 branch June 15, 2021 11:42
@systay systay mentioned this pull request Jun 15, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants