VReplication Reverse Workflows: add keyspace scope to vindex while creating reverse vreplication streams #8385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For sharded streams we add filters like
select * from customer where in_keyrange(customer_id, 'keyspace1.hash', '-7f')where the vindex is scoped by the source keyspace. This is needed since other keyspaces might also contain vindexes of the same name and using just the vindex name would create an ambiguity.This logic was missing while creating reverse streams which this PR adds.
Signed-off-by: Rohit Nayak rohit@planetscale.com
Related Issue(s)
#8259
Checklist