Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore SBR statements from pt-table-checksum #8396

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Ignore SBR statements from pt-table-checksum #8396

merged 1 commit into from
Jul 6, 2021

Conversation

rohit-nayak-ps
Copy link
Contributor

Signed-off-by: Rohit Nayak rohit@planetscale.com

Description

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@rohit-nayak-ps
Ignore SBR statements from pt-table-checksum
51101f7 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: VReplication labels Jun 29, 2021
@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review July 6, 2021 08:45
shlomi-noach
shlomi-noach approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, let's extract the if logic into a function

@rohit-nayak-ps rohit-nayak-ps merged commit a56d641 into vitessio:main Jul 6, 2021
@rohit-nayak-ps rohit-nayak-ps deleted the rn-ignore-percona-checksum-rbr branch July 6, 2021 09:31
@rohit-nayak-ps rohit-nayak-ps mentioned this pull request Jul 26, 2021
Merged
rohit-nayak-ps added a commit that referenced this pull request Jul 26, 2021
@rohit-nayak-ps
Merge pull request #8536 from planetscale/rn-8403-release-11
cc2de83 
Backports of #8403 #8483 #8489 #8401 #8521 #8396 from main into release 11.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@aquarapid aquarapid Awaiting requested review from aquarapid

@deepthi deepthi Awaiting requested review from deepthi

Assignees
No one assigned
Labels
Component: VReplication Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohit-nayak-ps @shlomi-noach @frouioui