[vtctld] sleep/ping tablets #8826
Conversation
|
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
ajm188
force-pushed
the
am_vtctld_sleep_ping
branch
from
2e93566
to
e53673c
Compare
| // SleepTablet makes a SleepTablet gRPC call to a vtctld. | ||
| SleepTablet = &cobra.Command{ | ||
| Use: "SleepTablet <alias> <duration>", | ||
| Short: "Blocks the action queue on the specified tablet for the specified amount of time. This is typically used for testing.", |
There was a problem hiding this comment.
Maybe an inline example would be helpful for "specified amount of time"? (Unless it's super obvious to Vitess operators.) We could steal what's noted here
The value is a string that contains a possibly signed sequence of decimal numbers, each with optional fraction and a unit suffix, such as “300ms” or “1h45m”
| if err != nil { | ||
| return nil, err | ||
| } else if !ok { | ||
| dur = *topo.RemoteOperationTimeout |
There was a problem hiding this comment.
I'm kinda surprised that we don't return if we can't parse the duration. Does using RemoteOperationTimeout here mean "sleep for the maximum timeout"? Or will tmc.Sleep fail?
(I did a bit of hunting in the codebase to answer this for myself but wound up in an interface declaration, and Sleep is... a cumbersome search term, haha.)
There was a problem hiding this comment.
the three-tuple here is (parsedDuration, wasDurationSet, error), so if the duration is nil you get back 0, false, nil, and we default to *topo.RemoteOperationTimeout. If we actually fail to parse, then the third value is non-nil and we take the earlier case (err != nil)
There was a problem hiding this comment.
(it's named "ok" to mirror the map two-value semantic of (value, isThereAValue))
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Description
This PR migrates the
SleepandPinglegacy vtctl commands, renamed toSleepTabletandPingTabletsince that is the component they operate on.Demo
Related Issue(s)
#7135
Checklist
Deployment Notes