Added tokenizer support for NCHAR_STRING #9006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ritwizsinha <ritwizsinha0@gmail.com>
ritwizsinha
requested review from
GuptaManan100,
harshit-gangal and
systay
as code owners
ritwizsinha
added
Component: Query Serving
Type: Enhancement
Signed-off-by: ritwizsinha <ritwizsinha0@gmail.com>
Signed-off-by: ritwizsinha <ritwizsinha0@gmail.com>
|
needs to fix the conflicts |
GuptaManan100
approved these changes
Oct 18, 2021
Signed-off-by: ritwizsinha <ritwizsinha0@gmail.com>
frouioui
approved these changes
Oct 19, 2021
Signed-off-by: Manan Gupta <manan@planetscale.com>
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ritwizsinha ritwizsinha0@gmail.com
Description
This PR adds support for N'string literal' by adding token NCHAR_STRING in the tokenizer
Related Issue(s)
Fixes #8864
Checklist
Deployment Notes