Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added brackets in default value if column is of type TEXT, BLOB, GEOMETRY or JSON #9011

Merged
merged 3 commits into from
Oct 19, 2021
Merged

Added brackets in default value if column is of type TEXT, BLOB, GEOMETRY or JSON #9011

merged 3 commits into from
Oct 19, 2021

Conversation

ritwizsinha
Copy link
Contributor

@ritwizsinha ritwizsinha commented Oct 18, 2021 •
edited by GuptaManan100
Loading

Description

Added brackets with default value if column is of type TEXT, BLOB, GEOMETRY or JSON

Related Issue(s)

Fixes #8982

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@ritwizsinha
Added brackets in ast format if column is of type TEXT, BLOB, GEOMETR…
a2bbf26 
…Y or JSON

Signed-off-by: ritwizsinha <ritwizsinha0@gmail.com>
@ritwizsinha ritwizsinha added Component: Query Serving release notes Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Oct 18, 2021
GuptaManan100
GuptaManan100 requested changes Oct 18, 2021
View reviewed changes
go/vt/sqlparser/ast_format.go Outdated Show resolved Hide resolved
go/vt/sqlparser/ast_format.go Outdated Show resolved Hide resolved
@ritwizsinha
Added switch and moved function to ast_funcs
47fd45f 
Signed-off-by: ritwizsinha <ritwizsinha0@gmail.com>
@ritwizsinha ritwizsinha changed the title Added brackets in ast format if column is of type TEXT, BLOB, GEOMETRY or JSON Added brackets in default value if column is of type TEXT, BLOB, GEOMETRY or JSON Oct 18, 2021
GuptaManan100
GuptaManan100 approved these changes Oct 18, 2021
View reviewed changes
go/vt/sqlparser/ast_funcs.go Outdated Show resolved Hide resolved
@ritwizsinha
Changed function name
aafde7c 
Signed-off-by: ritwizsinha <ritwizsinha0@gmail.com>
@GuptaManan100 GuptaManan100 merged commit 9c4b4db into vitessio:main Oct 19, 2021
@GuptaManan100 GuptaManan100 mentioned this pull request Oct 19, 2021
Merged
3 tasks
@ritwizsinha ritwizsinha mentioned this pull request Nov 22, 2021
Open
18 tasks
@arthurschreiber arthurschreiber mentioned this pull request Nov 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't set default value for BLOB, TEXT, GEOMETRY or JSON column
2 participants
@ritwizsinha @GuptaManan100