[wrangler] Cleanup duplicate wrangler methods #9015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
…ld method directly Signed-off-by: Andrew Mason <amason@slack-corp.com>
…ls` method directly Signed-off-by: Andrew Mason <amason@slack-corp.com>
…rectly Also fix some wonky import ordering/sections Signed-off-by: Andrew Mason <amason@slack-corp.com>
GuptaManan100
added a commit
to planetscale/vitess-operator
that referenced
this pull request
Apr 5, 2022
…was deleted in vitessio/vitess#9015 Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
added a commit
to planetscale/vitess-operator
that referenced
this pull request
Apr 5, 2022
…t was deleted in vitessio/vitess#9015 Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
added a commit
to planetscale/vitess-operator
that referenced
this pull request
Apr 20, 2022
…was deleted in vitessio/vitess#9015 Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
added a commit
to planetscale/vitess-operator
that referenced
this pull request
Apr 20, 2022
…t was deleted in vitessio/vitess#9015 Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
added a commit
to planetscale/vitess-operator
that referenced
this pull request
Jun 1, 2022
* feat: upgrade vitess version to 13.0 Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: update e2e tests to use 13.0.0 and latest images Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: move DeleteKeyspace to use vtctldServer in wrangler - since it was deleted in vitessio/vitess#9015 Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: move RemoveShardCelle to use vtctldServer in wrangler - since it was deleted in vitessio/vitess#9015 Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: move GetSchema to use vtctldServer in wrangler - since it was deleted in vitessio/vitess#9123 Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add double dash to vtctlclient command Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: pass false for the semi-sync parameter not being used in Vites Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: set a duraiblity_policy in the beginning to prevent panics Signed-off-by: Manan Gupta <manan@planetscale.com> * docs: add the Vitess PR that uses the durability policy stored in the keyspace information in the code comments Signed-off-by: Manan Gupta <manan@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does some cleanup, removing duplicated wrangler code in favor of calling the "new" (read: nearly–copy-pasted) implementations in grpvtctldserver.
Related Issue(s)
Checklist
Deployment Notes