Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vtctldclient-codegen] Add support in codegen for streaming RPCs #9064

Merged
merged 3 commits into from
Oct 27, 2021
Merged

[vtctldclient-codegen] Add support in codegen for streaming RPCs #9064

merged 3 commits into from
Oct 27, 2021

Commits on Oct 22, 2021

  1. Add streaming rpc support in localclient 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    c99bbcb View commit details
    Browse the repository at this point in the history

  2. Ensure the errch is buffered 

    (and also the individual message channels, because i don't actually
understand why this can't be unbuffered and so i'd rather not think
about it)

Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    07c1fe6 View commit details
    Browse the repository at this point in the history

  3. Appease the linter 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    57270a5 View commit details
    Browse the repository at this point in the history