Support ALTER VITESS_MIGRATION ... CLEANUP statement #9160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
shlomi-noach
added
Type: Enhancement
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
|
ready for review |
GuptaManan100
approved these changes
Nov 10, 2021
deepthi
approved these changes
Nov 17, 2021
doc/releasenotes/13_0_0_summary.md
Outdated
| ```sql | ||
| alter vitess_migration '9748c3b7_7fdb_11eb_ac2c_f875a4d24e90' cleanup | ||
| ``` | ||
| This query tells Vitess that a migration's artifacts are good to be cleaned up asap. This allows Vitess to free disk resources sooner. As reminder, once a migration's artifacts are cleaned up, the migration is no |
There was a problem hiding this comment.
Suggested change
| This query tells Vitess that a migration's artifacts are good to be cleaned up asap. This allows Vitess to free disk resources sooner. As reminder, once a migration's artifacts are cleaned up, the migration is no | |
| This query tells Vitess that a migration's artifacts are good to be cleaned up asap. This allows Vitess to free disk resources sooner. As a reminder, once a migration's artifacts are cleaned up, the migration is no |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
|
I resolved conflicts with |
|
Documentation PR: vitessio/website#886 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #9158 (9158 is unmerged yet, this PR extends it)
Tracking: #6926
This PR offers a new statement:
alter vitess_migration '9748c3b7_7fdb_11eb_ac2c_f875a4d24e90' cleanupNormally, when a migration is complete, it takes
24h(or however-retain_online_ddl_tablesis configured) until the artifacts are garbage collected and removed.With this new SQL statement we can tell vitess that a migration's artifacts are good to garbage collect now. The statement itself does not clean the artifacts, and returns immediately. It merely sets a small (negative) value to
retain_artifacts_seconds(see #9158) so that the next poll interval, typically a matter of seconds, can pick up on those artifacts and begin the garbage collection process.Notice that once a migration's artifacts are cleaned up, the migration may not be eligible for revert.
Checklist
Docs are required.