VReplication Workflow Create: Check for Copying state while waiting for streams to start #9206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Workflow Create polls the status of all vreplication streams for timeout seconds (default:30) and reports an error if all streams are deemed not to have started.
Currently we poll for each stream to reach the Running state. This is incorrect we start with the copy phase which can take a significant amount of time for large data. This PR also checks for the Copying state.
It is expected that, if the workflow is configured correctly, the default 30 seconds will be enough for all streams to find source tablets to start the copy phase.
Signed-off-by: Rohit Nayak rohit@planetscale.com
Related Issue(s)
#9000
Checklist