-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make PRS use Durability Rules #9259
Merged
GuptaManan100
merged 5 commits into
vitessio:main
from
planetscale:prs-durability-rules
Nov 30, 2021
Merged
Make PRS use Durability Rules #9259
GuptaManan100
merged 5 commits into
vitessio:main
from
planetscale:prs-durability-rules
Nov 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… policies as well Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
3 tasks
deepthi
approved these changes
Nov 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but maybe good to wait for @ajm188 to take a look as well.
ajm188
approved these changes
Nov 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment wording nitpick, then good to merge after that!
Signed-off-by: Manan Gupta <manan@planetscale.com>
…ty-rules Signed-off-by: Manan Gupta <manan@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Cluster management
Component: VTorc
Vitess Orchestrator integration
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the PR #8492, ERS was changed to use the durability policies to find the ideal candidate for being the primary. This PR makes that change to PRS. The only functionality which has been changed pertains to choosing the next primary. Instead of using the position sorter to find the most advanced tablet, we will now use the same function that ERS does for sorting the tablets and take the best alternative.
Related Issue(s)
Checklist
Deployment Notes