Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PRS use Durability Rules #9259

Merged
merged 5 commits into from
Nov 30, 2021

Conversation

GuptaManan100
Copy link
Member

Description

In the PR #8492, ERS was changed to use the durability policies to find the ideal candidate for being the primary. This PR makes that change to PRS. The only functionality which has been changed pertains to choosing the next primary. Instead of using the position sorter to find the most advanced tablet, we will now use the same function that ERS does for sorting the tablets and take the best alternative.

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

… policies as well

Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but maybe good to wait for @ajm188 to take a look as well.

Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment wording nitpick, then good to merge after that!

go/vt/vtctl/reparentutil/reparent_sorter.go Outdated Show resolved Hide resolved
Signed-off-by: Manan Gupta <manan@planetscale.com>
…ty-rules

Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 merged commit 9138b70 into vitessio:main Nov 30, 2021
@GuptaManan100 GuptaManan100 deleted the prs-durability-rules branch November 30, 2021 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Cluster management Component: VTorc Vitess Orchestrator integration Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants