Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gen4: filter on derived union system table with star projection #9263

Merged
merged 2 commits into from
Nov 19, 2021
Merged

Gen4: filter on derived union system table with star projection #9263

merged 2 commits into from
Nov 19, 2021

Conversation

harshit-gangal
Copy link
Member

Description

This PR add support for filter on derived union system table with star projection.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@harshit-gangal
feat: support pushpredicate in concatenate operator for starExpr proj…
a9bd95d 
…ection case only

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
test: added planner test for select on derived union case on system t…
d64f727 
…able with filter

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving release notes labels Nov 18, 2021
GuptaManan100
GuptaManan100 reviewed Nov 18, 2021
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, how does this change fix the panic? The planbuilding would have failed if we tried pushing predicate on the concatenate, or are we ignoring the error from this somewhere?

@harshit-gangal
Copy link
Member Author

harshit-gangal commented Nov 18, 2021 •
edited
Loading

Also, how does this change fix the panic? The planbuilding would have failed if we tried pushing predicate on the concatenate, or are we ignoring the error from this somewhere?

panic was fixed by other PR, this is a follow-up issue.
more details are present in the same issue comments.

@harshit-gangal harshit-gangal merged commit d6b2258 into vitessio:main Nov 19, 2021
@harshit-gangal harshit-gangal deleted the derived-union-systable-filter branch November 19, 2021 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@frouioui frouioui frouioui approved these changes

@systay systay Awaiting requested review from systay systay is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typeorm: add support for information schema query coming from framework
3 participants
@harshit-gangal @frouioui @GuptaManan100