Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge InitShardPrimary functionality into PlannedReparentShard #9276

Merged
merged 18 commits into from
Dec 17, 2021
Merged

Merge InitShardPrimary functionality into PlannedReparentShard #9276

merged 18 commits into from
Dec 17, 2021

Conversation

GuptaManan100
Copy link
Member

@GuptaManan100 GuptaManan100 commented Nov 23, 2021 •
edited
Loading

Description

This PR merges the functionality of InitShardPrimary and PlannedReparentShard, so that just calling PRS even for initialisation would be sufficient.

However, PlannedReparentShard would not do the destructive step of copying the executed gtid set from the new primary to all the other replicas. PlannedReparentShard is meant to be used for non-destructive repairable operations. For this use case, it is still advised that users use InitShardPrimary.

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required Documentation is required to say that PRS should be goto option to initialise the cluster Update docs for ISP and PRS website#930

Deployment Notes

@GuptaManan100
test: added e2e test for using prs instead of isp for initialization
fe3a0c3 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
feat: added the capability to PRS to initialize the shard as well
e80a9c5 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
test: fixed unit tests for planned_reparent_shard
dac9a34 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
test: added unit tests for performInitialPromotion
7a67d04 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
test: added a test to check that PRS works when no new primary is pro…
3f1a876 
…vided

Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
test: fixed unit test for planned reparent shard
6af50ee 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
feat: call refreshState rpc when initializing primary to setup auxill…
0c63cff 
…ary components correctly

Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
feat: initPrimary should be using the reset functionality instead of …
6c0fcf0 
…setting the replication to stopped

Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
test: start initializing cluster with PRS instead of ISP
232b990 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
test: use PRS instead of ISP in cell_alias_test
9b21bd4 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
test: use isp in upgrade downgrade testing
9bda98f 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
test: make more tests use InitShardPrimary
f9868ec 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 marked this pull request as ready for review December 10, 2021 12:27
@GuptaManan100
test: don't create database explicitly, before calling PRS
09452e4 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
chore: fix the comments in tests
22bf563 
Signed-off-by: Manan Gupta <manan@planetscale.com>
deepthi
deepthi approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work!
Let's wait for @sougou to give it a once-over before we merge.
Can you fix the little things I found in the meantime?

go/test/endtoend/vreplication/cluster.go Outdated Show resolved Hide resolved
go/vt/vtctl/reparentutil/planned_reparenter.go Outdated Show resolved Hide resolved
go/vt/vtctl/reparentutil/planned_reparenter.go Outdated Show resolved Hide resolved
@GuptaManan100
refactor: rename a variable in planned_reparenter
9750cb2 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
Merge remote-tracking branch 'upstream/main' into merge-isp-prs
7a6cbbe 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
test: fixed comments for InitializeShard
3ab23f4 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
Merge remote-tracking branch 'upstream/main' into merge-isp-prs
d845816 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 merged commit 20ca75a into vitessio:main Dec 17, 2021
@GuptaManan100 GuptaManan100 deleted the merge-isp-prs branch December 17, 2021 03:36
@GuptaManan100 GuptaManan100 mentioned this pull request Dec 30, 2021
Merged
@GuptaManan100 GuptaManan100 mentioned this pull request Jan 14, 2022
Merged
3 tasks
@GuptaManan100 GuptaManan100 mentioned this pull request Jan 27, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sougou sougou sougou approved these changes

@deepthi deepthi deepthi approved these changes

@ajm188 ajm188 Awaiting requested review from ajm188 ajm188 is a code owner

@rafael rafael Awaiting requested review from rafael

@doeg doeg Awaiting requested review from doeg

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

Assignees
No one assigned
Labels
Component: Cluster management Component: VTorc Vitess Orchestrator integration Type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuptaManan100 @deepthi @sougou